Skip to content

Update documentations for electron sourcemaps #29280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented May 12, 2025

What does this PR do? What is the motivation?

We don't support unminification for Electron apps hosted in local files due to the stack trace prefix file://. We should mention this in the public documentation for clarification.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@cy-moi cy-moi force-pushed the congyao/update-doc-for-electron-sourcemaps branch from 2969cba to 369fd6d Compare May 12, 2025 13:11
@github-actions github-actions bot added the Guide Content impacting a guide label May 12, 2025
Copy link
Contributor

@cy-moi cy-moi force-pushed the congyao/update-doc-for-electron-sourcemaps branch from 369fd6d to ff404ec Compare May 12, 2025 13:19
@cy-moi cy-moi force-pushed the congyao/update-doc-for-electron-sourcemaps branch from ff404ec to 167d050 Compare May 12, 2025 13:34
@datadog-datadog-prod-us1
Copy link

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@cy-moi cy-moi marked this pull request as ready for review May 12, 2025 13:50
@cy-moi cy-moi requested review from a team as code owners May 12, 2025 13:50
@brett0000FF brett0000FF self-assigned this May 12, 2025
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--just two minor suggestions. Thanks!

cy-moi and others added 2 commits May 13, 2025 10:27
…tions-using-browser-sdk.md

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
…tions-using-browser-sdk.md

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@cy-moi
Copy link
Contributor Author

cy-moi commented May 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2025

View all feedbacks in Devflow UI.

2025-05-13 13:46:53 UTC ℹ️ Start processing command /merge


2025-05-13 13:47:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-13 14:11:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a62089a into master May 13, 2025
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the congyao/update-doc-for-electron-sourcemaps branch May 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants